Skip to content

Conversation

Preetiraj3697
Copy link

No description provided.

@Preetiraj3697 Preetiraj3697 mentioned this pull request Apr 14, 2023
41 tasks
@@ -0,0 +1,27 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change. Please get rid of this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my code and merge it.


const binary: string = '1011';
const decimal: number = binaryToDecimal(binary);
console.log(`The decimal representation of ${binary} is ${decimal}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effect. Use a proper Jest test instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my code and merge it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effect. Use a proper Jest test instead.

@appgurueu please check my code and merge it.

@Preetiraj3697 Preetiraj3697 requested a review from appgurueu April 19, 2023 10:02
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Still no Jest test.
  • Still contains the unrelated prime check addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants